Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Prometheus metrics for Certificate ready status #1811

Merged
merged 5 commits into from Jul 15, 2019
Merged

Add Prometheus metrics for Certificate ready status #1811

merged 5 commits into from Jul 15, 2019

Conversation

cheukwing
Copy link
Contributor

@cheukwing cheukwing commented Jun 20, 2019 •
edited

What this PR does / why we need it:
Adds metrics to track the ready status of certificates.
Built over/modified from @seleznev's patch.

Also refactors the clean up to use a cleanUpFunctions slice.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #1679

Release note:

Add Prometheus metrics for tracking Certificate readiness

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jun 20, 2019
@jetstack-bot jetstack-bot added area/monitoring Indicates a PR or issue relates to monitoring size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 20, 2019
@cheukwing cheukwing changed the title WIP: Add Prometheus metrics for Certificate ready status Add Prometheus metrics for Certificate ready status Jun 21, 2019
@jetstack-bot jetstack-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 21, 2019
@munnerz munnerz added this to the v0.9 milestone Jul 3, 2019
@munnerz munnerz added this to Review in progress in v0.9 Jul 5, 2019
cheukwing and others added 5 commits July 10, 2019 08:52
@cheukwing @seleznev
Add prometheus metric for certificate ready condition
6fa8e3d 
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
Co-authored-by: Aleksandr Seleznev <alex@slznv.net>
@cheukwing @seleznev
Add tests for updating certificate status
19eeb21 
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
Co-authored-by: Aleksandr Seleznev <alex@slznv.net>
@cheukwing
Add UpdateCertificateStatus call, comment implementation
f3baab0 
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
@cheukwing
Add cleanup function slice
1317b8d 
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
@cheukwing
Add comments to refactored metric clean up
c2fd63a 
Signed-off-by: Michael Tsang <michael.tsang@jetstack.io>
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2019
@JoshVanL
Copy link
Collaborator

/assign

@JoshVanL
Copy link
Collaborator

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@munnerz
Copy link
Member

munnerz commented Jul 15, 2019

/approve

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheukwing, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 15, 2019
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@jetstack-bot jetstack-bot merged commit 65138f5 into cert-manager:master Jul 15, 2019
v0.9 automation moved this from Review in progress to Done Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz Awaiting requested review from munnerz

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Indicates a PR or issue relates to monitoring dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
v0.9
  
Done
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Prometheus metric for certificate ready condition
5 participants
@cheukwing @JoshVanL @munnerz @jetstack-bot @retest-bot