Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CertificateRequest "KEP" #1866

Merged
merged 2 commits into from
Jul 9, 2019
Merged

CertificateRequest "KEP" #1866

merged 2 commits into from
Jul 9, 2019

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Jul 8, 2019

/hold

Adds CertificateRequest proposal

@JoshVanL
Adds first CertificateRequest "KEP" draft
a768624 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/design Categorizes issue or PR as related to design. labels Jul 8, 2019
@jetstack-bot jetstack-bot requested a review from munnerz July 8, 2019 15:59
@jetstack-bot jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 8, 2019
munnerz
munnerz reviewed Jul 9, 2019
View reviewed changes
Copy link
Member

@munnerz munnerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great 🎉

design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
design/20190708.certificate-request-crd.md Show resolved Hide resolved
design/20190708.certificate-request-crd.md Outdated Show resolved Hide resolved
@JoshVanL
Adds some minor changes to clarity, grammar and spelling
2d9ced2 
Signed-off-by: JoshVanL <vleeuwenjoshua@gmail.com>
@JoshVanL JoshVanL changed the title WIP: CertificateRequest "KEP" CertificateRequest "KEP" Jul 9, 2019
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jul 9, 2019

/hold cencel

@JoshVanL
Copy link
Contributor Author

JoshVanL commented Jul 9, 2019

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2019
@munnerz
Copy link
Member

munnerz commented Jul 9, 2019

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@jetstack-bot jetstack-bot merged commit b76c3f7 into cert-manager:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @munnerz @jetstack-bot