Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable validation and mutation for subresources #2283

Merged
merged 1 commit into from Oct 28, 2019
Merged

Enable validation and mutation for subresources #2283

merged 1 commit into from Oct 28, 2019

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Oct 25, 2019

What this PR does / why we need it:

As per the matching requests documentation, we need to opt-in to having the status subresource matched by our validating/mutating webhooks.

Release note:

Perform API resource validation of the 'status' subresource on cert-manager resources

/area api
/milestone v0.12

@munnerz
Enable validation and mutation for subresources
374c293 
Signed-off-by: James Munnelly <james@munnelly.eu>
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 25, 2019
@jetstack-bot jetstack-bot added this to the v0.12 milestone Oct 25, 2019
@jetstack-bot jetstack-bot added area/api Indicates a PR directly modifies the 'pkg/apis' directory dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 25, 2019
@jetstack-bot jetstack-bot added the area/deploy Indicates a PR modifies deployment configuration label Oct 25, 2019
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2019
@munnerz munnerz added this to Review in progress in v0.12 Oct 28, 2019
@JoshVanL
Copy link
Collaborator

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2019
@jetstack-bot jetstack-bot merged commit 2cf195a into cert-manager:master Oct 28, 2019
v0.12 automation moved this from Review in progress to Done Oct 28, 2019
@munnerz munnerz added the kind/bug Categorizes issue or PR as related to a bug. label Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz Awaiting requested review from kragniz

Assignees

@JoshVanL JoshVanL

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
v0.12
  
Done
Milestone
v0.12
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@munnerz @jetstack-bot @JoshVanL