Fix panic when ACME server returns a genuine error #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
jetstack-bot
added
the
size/S
munnerz
force-pushed
the
fix-acme-reg-panic
branch
from
573ccba
to
ea1dc8f
Compare
munnerz
added
lgtm
|
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
This was referenced Jan 10, 2018
jetstack-ci-bot
added a commit
that referenced
this pull request
Jan 15, 2018
#239-#240-#216-upstream-release-0.2 Automatic merge from submit-queue. Automated cherry pick of #221 #237 #239 #240 #216 Cherry pick of #221 #237 #239 #240 #216 on release-0.2. #221: Update Secrets instead of replacing to preserve additional #237: Fix panic when ACME server returns a genuine error #239: Update dates in generated license headers #240: Fix typo in acme-http-validation.md #216: Use cert-manager installed via helm in e2e tests
|
Commit found in the "release-0.2" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
TheEnbyperor
added a commit
to AS207960/cert-manager
that referenced
this pull request
Aug 7, 2020
Signed-off-by: Q <q@as207960.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixes a panic when an error other than HTTP Conflict is returned from the ACME server during registration.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Fixes #236
Release note:
/assign