Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve helm installation docs #255

Closed
wants to merge 1 commit into from
Closed

Improve helm installation docs #255

wants to merge 1 commit into from

Conversation

ahmetb
Copy link

@ahmetb ahmetb commented Jan 16, 2018

It wasn't unclear to me that the chart name comes from the filesystem.

Also adding a complete instructions list for installing Helm parts.

NONE

@ahmetb
Improve helm installation docs
40931c8 
It wasn't unclear to me that the chart name comes from the filesystem.

Also adding a complete instructions list for installing Helm parts.
@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. retest-not-required-docs-only labels Jan 16, 2018
@jetstack-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2018
@jetstack-bot
Copy link
Contributor

Hi @ahmetb. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-ci-bot jetstack-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 18, 2018
@jetstack-ci-bot
Copy link
Contributor

@ahmetb PR needs rebase

@munnerz
Copy link
Member

munnerz commented Jan 18, 2018

Going to close this now as the changes have been incorporated into my other PR #264

@munnerz munnerz closed this Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@munnerz munnerz

@simonswine simonswine

Labels
needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ahmetb @jetstack-ci-bot @jetstack-bot @munnerz @simonswine