Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't perform ACME validation if user account already holds valid authorization #26

Closed
wants to merge 1 commit into from
Closed

Don't perform ACME validation if user account already holds valid authorization #26

wants to merge 1 commit into from

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Aug 7, 2017 •
edited

This implements the functionality described here: #16

If the ACME Issuer being used already holds an authorization for the requested domain, we now skip acquiring the authorization. The downside to this, is that users will find out at renewal time that a particular authorization mechanism is no longer working, as opposed to at the time of first issue. Grateful for feedback/opinions on this change!

Re-use ACME validations previously obtained by an Issuer

@munnerz munnerz mentioned this pull request Aug 7, 2017
Closed
@munnerz
Copy link
Member Author

munnerz commented Oct 22, 2017

Thoughts on whether this should be rebased & merged?

/cc @dippynark @simonswine @mikebryant

@munnerz
Copy link
Member Author

munnerz commented Oct 22, 2017

Sorry, probably best to discuss in #16

@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 23, 2017
@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@munnerz
Copy link
Member Author

munnerz commented Oct 23, 2017

/lint

jetstack-bot
jetstack-bot reviewed Oct 23, 2017
View reviewed changes
Copy link
Contributor

@jetstack-bot jetstack-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@munnerz: 0 warnings.

In response to this:

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 23, 2017
@munnerz munnerz closed this Oct 23, 2017
@munnerz munnerz reopened this Oct 23, 2017
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: munnerz

Assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@jetstack-bot
Copy link
Contributor

@munnerz PR needs rebase

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2017
@munnerz
Copy link
Member Author

munnerz commented Oct 23, 2017

/hold

@munnerz munnerz assigned simonswine and unassigned simonswine and dippynark Nov 2, 2017
@jetstack-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
We suggest the following additional approver: simonswine

Assign the PR to them by writing /assign @simonswine in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@munnerz munnerz mentioned this pull request Jan 18, 2018
Closed
@munnerz munnerz closed this Feb 28, 2018
@munnerz munnerz deleted the disable-revalidate branch February 28, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jetstack-bot jetstack-bot jetstack-bot left review comments

Assignees

@simonswine simonswine

Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@munnerz @jetstack-bot @jetstack-ci-bot @simonswine @dippynark