Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACME DNS-01 provider for Akamai FastDNS #322

Merged
merged 2 commits into from
Apr 4, 2018
Merged

Add ACME DNS-01 provider for Akamai FastDNS #322

merged 2 commits into from
Apr 4, 2018

Conversation

twz123
Copy link
Contributor

@twz123 twz123 commented Feb 21, 2018 •
edited

What this PR does / why we need it:
Using cert-manager's ACME DNS-01 challenge with DNS zones managed by Akamai.

Which issue this PR fixes: -

Special notes for your reviewer:

Release note:

Add ACME DNS-01 provider for Akamai FastDNS

@jetstack-bot jetstack-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 21, 2018
@munnerz munnerz added this to the v0.3 milestone Feb 21, 2018
@jetstack-ci-bot
Copy link
Contributor

@twz123 PR needs rebase

@jetstack-ci-bot jetstack-ci-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2018
@jetstack-ci-bot jetstack-ci-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 22, 2018
@jetstack-bot jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 22, 2018
munnerz
munnerz reviewed Mar 23, 2018
View reviewed changes
docs/api-types/issuer/spec.md

```yaml
akamai:
serviceConsumerDomain: akab-tho6xie2aiteip8p-poith5aej0ughaba.luna.akamaiapis.net
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to check: one service consumer domain can be used to manage multiple DNS zones, right? Or does this field dictate which DNS zone can be updated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, those service consumer domains are connected to their respective Akamai account. The domain can therefore be used to manage all zones belonging to that account. AFAIK there's no way to restrict the zones.

@munnerz
Copy link
Member

munnerz commented Mar 23, 2018

I've not got a way to test this as I don't have an Akamai account to hand. Can you/anyone confirm this is working?

/ok-to-test

@jetstack-bot jetstack-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 23, 2018
@twz123
Copy link
Contributor Author

twz123 commented Mar 30, 2018

We're using this version in our cluster since approximately a month now. Initial requests to Let's Encrypt work. Next cert renewal would be in ~2 months, but since requesting works, I don't expect any issues with the renewal part.

@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

Thanks for your work on this - let's get this merged now and we can start gathering some user feedback 😄

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2018
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2018
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

4 similar comments
@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@retest-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to jetstack).
Review the full test history for this PR.
Silence the bot with an /lgtm cancel comment for consistent failures.

@munnerz munnerz mentioned this pull request Apr 4, 2018
Closed
@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

/test e2e

@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

/skip

@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

Sorry for all the comment spam - the test flake has now been resolved!

@jetstack-bot
Copy link
Contributor

jetstack-bot commented Apr 4, 2018 •
edited

@twz123: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
cert-manager-e2e-v1-10 f681f5a link /test e2e v1.10

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@munnerz
Copy link
Member

munnerz commented Apr 4, 2018

/retest

@jetstack-bot jetstack-bot merged commit acfc2f7 into cert-manager:master Apr 4, 2018
@munnerz munnerz mentioned this pull request Jun 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@munnerz munnerz munnerz left review comments

Assignees

@munnerz munnerz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@twz123 @jetstack-ci-bot @munnerz @jetstack-bot @retest-bot