Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DNSimple DNS Issuer #483

Closed
wants to merge 18 commits into from
Closed

DNSimple DNS Issuer #483

wants to merge 18 commits into from

Conversation

marc-sensenich
Copy link

@marc-sensenich marc-sensenich commented Apr 16, 2018 •
edited

What this PR does / why we need it:
Adds a DNS issuer for DNSimple

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #472

Special notes for your reviewer:

Release note:

Add DNSimple as a DNS Issuer

@jetstack-bot jetstack-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 16, 2018
@marc-sensenich marc-sensenich changed the title DNSimple DNS Provider [WIP] DNSimple DNS Provider Apr 16, 2018
@jetstack-bot jetstack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2018
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 16, 2018
@marc-sensenich marc-sensenich changed the title [WIP] DNSimple DNS Provider [WIP] DNSimple DNS Issuer Apr 16, 2018
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 16, 2018
marc-sensenich
marc-sensenich commented Apr 16, 2018
View reviewed changes
Gopkg.lock Outdated
"autorest/date",
"autorest/to"
]
packages = ["autorest","autorest/adal","autorest/azure","autorest/date","autorest/to"]
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time using dep on an upstream project and dep ensure is formatting them as such. This is most likely due to me not being familiar enough with the tool to know the formatting options for the tool

@marc-sensenich marc-sensenich mentioned this pull request Apr 16, 2018
Closed
@munnerz munnerz added area/acme Indicates a PR directly modifies the ACME Issuer code and removed area/acme Indicates a PR directly modifies the ACME Issuer code labels Apr 25, 2018
@marc-sensenich marc-sensenich changed the title [WIP] DNSimple DNS Issuer DNSimple DNS Issuer Apr 27, 2018
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2018
@marc-sensenich
Copy link
Author

/assign @munnerz

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2018
@munnerz munnerz added this to the v0.4 milestone May 9, 2018
@dobesv
Copy link
Contributor

dobesv commented May 14, 2018

Hey, I'm hoping to use this by the end of the month to renew my letsenscrypt certificate. Anything I can do to help move this forwards?

@munnerz
Copy link
Member

munnerz commented May 24, 2018

/ok-to-test

@jetstack-bot jetstack-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 24, 2018
@munnerz
Copy link
Member

munnerz commented May 24, 2018

Re-assigning to get this reviewed sooner 😄

/cc @kragniz
/assign @kragniz
/unassign @munnerz

@jetstack-bot jetstack-bot assigned kragniz and unassigned munnerz May 24, 2018
@munnerz munnerz added this to To do in v0.4 via automation May 24, 2018
@munnerz munnerz moved this from To do to In progress in v0.4 May 24, 2018
@marc-sensenich
Copy link
Author

@dobesv I'll take a look at this again this evening or tomorrow and work through the failing issues to move this forward

@munnerz Thanks for that!

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: munnerz

If they are not already assigned, you can assign the PR to them by writing /assign @munnerz in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2018
@marc-sensenich
Copy link
Author

/retest

@marc-sensenich
Copy link
Author

/test chart-verify

@marc-sensenich
Copy link
Author

marc-sensenich commented Jul 17, 2018 •
edited

/test e2e v1.9

@marc-sensenich
Copy link
Author

/retest

@marc-sensenich
Copy link
Author

/retest

@marc-sensenich
Copy link
Author

@kragniz this is ready for review

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2018
@jetstack-bot
Copy link
Contributor

@marc-sensenich: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@munnerz munnerz assigned kragniz and unassigned munnerz Jul 25, 2018
@JannikZed
Copy link

Is there already a timeline, when this request will be merged? We are waiting for it since a very long time and need to issue certificates manually right now

@munnerz munnerz modified the milestones: v0.5, v0.6 Sep 13, 2018
@marc-sensenich marc-sensenich mentioned this pull request Sep 22, 2018
Closed
@marc-sensenich
Copy link
Author

Due to the time elapsed and changes in the project since this PRs opening. I have opened a new PR #920 to replace this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kragniz kragniz Awaiting requested review from kragniz

Assignees

@kragniz kragniz

Labels
area/acme Indicates a PR directly modifies the ACME Issuer code needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
No open projects
v0.4
  
In progress
Milestone
v0.6
Development

Successfully merging this pull request may close these issues.

DNSSimple support
8 participants
@marc-sensenich @dobesv @munnerz @Nowaker @shortcircuit3 @jetstack-bot @JannikZed @kragniz