Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook feature gate #6093

Merged
merged 4 commits into from May 24, 2023
Merged

Commits on May 23, 2023

  1. Don't import controller's feature gate setup into a shared library

    To prevent controller's feature gates from overwriting other component's feature gates
    
    Signed-off-by: irbekrm <irbekrm@gmail.com>
    irbekrm committed May 23, 2023
    Configuration menu
    Copy the full SHA
    b1a5916 View commit details
    Browse the repository at this point in the history
  2. Adds some warnings for folks to not import feature gates into shared …

    …code
    
    Really we should restructure this to remove the possibility of accidentally overwriting other component's feature gates
    
    Signed-off-by: irbekrm <irbekrm@gmail.com>
    irbekrm committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8a34cbc View commit details
    Browse the repository at this point in the history
  3. Fix a bug in helm chart where webhook had controller feature gates pa…

    …ssed
    
    This will break anyone who relied on featureGates field to pass feature gates to webhook- they will need to use the new webhook.featureGates field
    
    Signed-off-by: irbekrm <irbekrm@gmail.com>
    irbekrm committed May 23, 2023
    Configuration menu
    Copy the full SHA
    acf0741 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. fix typo

    Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
    inteon committed May 24, 2023
    Configuration menu
    Copy the full SHA
    55ebaa3 View commit details
    Browse the repository at this point in the history