Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature gates: promote StableCertificateRequestName and SecretsFilteredCaching to Beta #6298

Merged
merged 3 commits into from Aug 30, 2023
Merged

Feature gates: promote StableCertificateRequestName and SecretsFilteredCaching to Beta #6298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
882b771
promote StableCertificateRequestName and SecretsFilteredCaching to Beta
inteon Aug 25, 2023
68cbbf8
update tests to work with StableCertificateRequestName featuregate be…
inteon Aug 25, 2023
b5dc93c
make myself the owner of StableCertificateRequestName, meaning I will…
inteon Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions internal/controller/feature/features.go
View file
Open in desktop
Expand Up @@ -81,8 +81,9 @@ const (
// See https://github.com/cert-manager/cert-manager/issues/3203 and https://github.com/cert-manager/cert-manager/issues/4424 for context.
LiteralCertificateSubject featuregate.Feature = "LiteralCertificateSubject"

// Owner: N/A
// Owner: @inteon
// Alpha: v1.10
// Beta: v1.13
//
// StableCertificateRequestName will enable generation of CertificateRequest resources with a fixed name. The name of the CertificateRequest will be a function of Certificate resource name and its revision
// This feature gate will disable auto-generated CertificateRequest name
Expand All @@ -99,6 +100,7 @@ const (

// Owner: @irbekrm
// Alpha v1.12
// Beta: v1.13
//
// SecretsFilteredCaching reduces controller's memory consumption by
// filtering which Secrets are cached in full using
Expand Down Expand Up @@ -127,14 +129,14 @@ func init() {
// available on the cert-manager controller binary.
var defaultCertManagerFeatureGates = map[featuregate.Feature]featuregate.FeatureSpec{
DisallowInsecureCSRUsageDefinition: {Default: true, PreRelease: featuregate.Beta},
StableCertificateRequestName: {Default: true, PreRelease: featuregate.Beta},
SecretsFilteredCaching: {Default: true, PreRelease: featuregate.Beta},

ValidateCAA: {Default: false, PreRelease: featuregate.Alpha},
ExperimentalCertificateSigningRequestControllers: {Default: false, PreRelease: featuregate.Alpha},
ExperimentalGatewayAPISupport: {Default: false, PreRelease: featuregate.Alpha},
AdditionalCertificateOutputFormats: {Default: false, PreRelease: featuregate.Alpha},
ServerSideApply: {Default: false, PreRelease: featuregate.Alpha},
LiteralCertificateSubject: {Default: false, PreRelease: featuregate.Alpha},
StableCertificateRequestName: {Default: false, PreRelease: featuregate.Alpha},
UseCertificateRequestBasicConstraints: {Default: false, PreRelease: featuregate.Alpha},
SecretsFilteredCaching: {Default: false, PreRelease: featuregate.Alpha},
}