Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm) Add support for PodMonitor #6459

Merged
merged 1 commit into from
Nov 16, 2023
Merged

feat(helm) Add support for PodMonitor #6459

merged 1 commit into from
Nov 16, 2023

Conversation

shlomitubul
Copy link

Pull Request Motivation
In the current chart, users are limited to using ServiceMonitor for metric scraping,
This PR aims to add support for PodMonitor, providing an alternative to ServiceMonitor and conserving ClusterIP services.

Kind
feature

Changes
Added support for configuring PodMonitor in the Helm Chart.
Implemented conditional logic to ensure PodMonitor and ServiceMonitor are mutually exclusive to avoid configuration errors.
Testing
Deployed the Helm chart with PodMonitor enabled and verified metrics scraping.
Deployed the Helm chart with ServiceMonitor enabled to ensure no regressions.
Deployed the Helm chart with both enabled to confirm that a configuration error is correctly thrown.

Release Note
feat(helm): Added support for PodMonitor to conserve ClusterIP services used solely for metrics.

@shlomitubul
feat(helm) Add support for PodMonitor
0a16c4e 
Signed-off-by: ShlomiTubul <shlomi.tubul@placer.ai>
@jetstack-bot
Copy link
Contributor

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 31, 2023
@jetstack-bot
Copy link
Contributor

Hi @shlomitubul. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Oct 31, 2023
@inteon
Copy link
Member

inteon commented Oct 31, 2023

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 31, 2023
@inteon
Copy link
Member

inteon commented Oct 31, 2023

I agree with the changes, I haven't tested the PR in detail yet, so this PR still needs an /lgtm before being merged.
/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2023
@shlomitubul
Copy link
Author

Is there anything from my side that I need to do?

@inteon
Copy link
Member

inteon commented Nov 16, 2023

/lgtm
Thanks for your contribution!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2023
@jetstack-bot jetstack-bot merged commit b0ed333 into cert-manager:master Nov 16, 2023
6 checks passed
This was referenced Feb 1, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlomitubul @jetstack-bot @inteon