Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.12] Mitigate potential Slowloris attacks by setting ReadHeaderTimeout in all http.Server instances #6539

Merged
merged 1 commit into from Dec 7, 2023
Merged

[release-1.12] Mitigate potential Slowloris attacks by setting ReadHeaderTimeout in all http.Server instances #6539

merged 1 commit into from Dec 7, 2023

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Dec 7, 2023

This is a manual cherry-pick of #6538 because the automated cherry-pick failed:

You can see that the patch is the same but the context is different using git range-diff:

git range-diff d080cec^- cad1189^-

image 
Mitigate potential Slowloris attacks by setting ReadHeaderTimeout in all http.Server instances

/kind bug

@wallrj
Add ReadHeaderTimeout to all http.Server where that setting is missing
cad1189 
Signed-off-by: Richard Wall <richard.wall@venafi.com>
(cherry picked from commit d080cec)
@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 7, 2023
@wallrj wallrj requested a review from inteon December 7, 2023 19:16
inteon
inteon reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2023
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2023
@jetstack-bot jetstack-bot merged commit 9c94184 into cert-manager:release-1.12 Dec 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallrj @jetstack-bot @inteon