Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cmctl from this repo (moved to https://github.com/cert-manager/cmctl) #6663

Merged
merged 1 commit into from Jan 25, 2024
Merged

Remove cmctl from this repo (moved to https://github.com/cert-manager/cmctl) #6663

merged 1 commit into from Jan 25, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Jan 24, 2024

We moved the cmctl code and CI/CD to the https://github.com/cert-manager/cmctl repo.

Kind

/kind cleanup

Release Note

`cmctl` and `kubectl cert-manger` have been moved to the https://github.com/cert-manager/cmctl repo and will be versioned separately starting with cmctl v2.0.0

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/testing Issues relating to testing labels Jan 24, 2024
@inteon inteon changed the title Remove cmctl from this repo Remove cmctl from this repo (moved to https://github.com/cert-manager/cmctl) Jan 24, 2024
@inteon inteon force-pushed the remove_ctl branch 5 times, most recently from 0c3ea47 to c384152 Compare January 24, 2024 15:08
@inteon
remove cmctl from this repo
7b94868 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@ThatsMrTalbot
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@inteon
Copy link
Member Author

inteon commented Jan 25, 2024

/approve

@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@jetstack-bot jetstack-bot merged commit b9e01e3 into cert-manager:master Jan 25, 2024
8 checks passed
@wallrj
Copy link
Member

wallrj commented Jan 30, 2024 •
edited

@inteon There are some lingering references to ctl in the repo and the testgrid is now failing for the ctl image:

@wallrj wallrj mentioned this pull request Jan 30, 2024
Closed
@inteon inteon mentioned this pull request Jan 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inteon @ThatsMrTalbot @jetstack-bot @wallrj