Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the azcore.ResponseError error message to make it stable across retries #6676

Merged
merged 2 commits into from Jan 30, 2024
Merged

Replace the azcore.ResponseError error message to make it stable across retries #6676

merged 2 commits into from Jan 30, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Jan 30, 2024

Similar to #5663, but for the new Azure SDK.
Fixes #5452 (comment)

Kind

/kind bug

Release Note

Make sure the Azure SDK error messages are stable.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jan 30, 2024
@inteon inteon requested a review from wallrj January 30, 2024 12:46
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code labels Jan 30, 2024
@inteon
Copy link
Member Author

inteon commented Jan 30, 2024

/cherrypick release-1.14

@jetstack-bot
Copy link
Collaborator

@inteon: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wallrj
wallrj requested changes Jan 30, 2024
View reviewed changes
pkg/issuer/acme/dns/azuredns/azuredns_test.go Outdated Show resolved Hide resolved
pkg/issuer/acme/dns/azuredns/azuredns_test.go Outdated Show resolved Hide resolved
pkg/issuer/acme/dns/azuredns/azuredns_test.go Show resolved Hide resolved
pkg/issuer/acme/dns/azuredns/azuredns.go Outdated Show resolved Hide resolved
pkg/issuer/acme/dns/azuredns/azuredns_test.go Outdated Show resolved Hide resolved
@inteon inteon force-pushed the azure_redact branch 2 times, most recently from 02adf67 to 0d9835f Compare January 30, 2024 15:02
@inteon
replace the azcore.ResponseError error message to make it stable acro…
90cbbc9 
…ss retries

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 30, 2024
@inteon inteon requested a review from wallrj January 30, 2024 15:29
wallrj
wallrj approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim

/lgtm

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 30, 2024
@wallrj
Copy link
Member

wallrj commented Jan 30, 2024

@weisdd Please take a look at this PR and let us know if you spot any problems.

@inteon
Copy link
Member Author

inteon commented Jan 30, 2024

/approve
/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2024
@inteon
improve error message logging
b9dd490 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
wallrj
wallrj approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon
Copy link
Member Author

inteon commented Jan 30, 2024

/unhold

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2024
@jetstack-bot jetstack-bot merged commit c187fed into cert-manager:master Jan 30, 2024
7 checks passed
@jetstack-bot
Copy link
Collaborator

@inteon: new pull request created: #6680

In response to this:

/cherrypick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot mentioned this pull request Jan 30, 2024
Merged
@inteon inteon mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallrj wallrj wallrj approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @jetstack-bot @wallrj