[release-1.14] Fix the Helm trick that we use to differentiate between 0 and an empty value #6729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y value Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
jetstack-bot
added
release-note
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
|
/retest |
|
/kind bug |
jetstack-bot
added
kind/bug
nrdufour
added a commit
to nrdufour/home-ops
that referenced
this pull request
Feb 11, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://github.com/cert-manager/cert-manager) | patch | `v1.14.1` -> `v1.14.2` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.14.2`](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.2) [Compare Source](cert-manager/cert-manager@v1.14.1...v1.14.2) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. cert-manager 1.14 brings a variety of features, security improvements and bug fixes, including: support for creating X.509 certificates with "Other Name" fields, and support for creating CA certificates with "Name Constraints" and "Authority Information Accessors" extensions. ##### ℹ️ Documentation [Release notes](https://cert-manager.io/docs/releases/release-notes/release-notes-1.14) [Upgrade notes](https://cert-manager.io/docs/releases/upgrading/upgrading-1.13-1.14) [Installation instructions](https://cert-manager.io/docs/installation/) ##### 🔧 Breaking changes See `Breaking changes` in [v1.14.0 release notes](https://github.com/cert-manager/cert-manager/releases/tag/v1.14.0) ##### 📜 Changes since `v1.14.1` ##### Bug or Regression - BUGFIX: cert-manager CA and SelfSigned issuers incorrectly copied the critical flag from the CSR instead of re-calculating that field themselves. ([#​6727](cert-manager/cert-manager#6727), [@​jetstack-bot](https://github.com/jetstack-bot)) - Helm: Fix a bug in the logic that differentiates between 0 and an empty value. ([#​6729](cert-manager/cert-manager#6729), [@​jetstack-bot](https://github.com/jetstack-bot)) ##### Other (Cleanup or Flake) - Bump golang to 1.21.7 ([#​6735](cert-manager/cert-manager#6735), [@​jetstack-bot](https://github.com/jetstack-bot)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xNzUuMyIsInVwZGF0ZWRJblZlciI6IjM3LjE3NS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Reviewed-on: https://git.home/nrdufour/home-ops/pulls/370 Co-authored-by: Renovate <renovate@ptinem.io> Co-committed-by: Renovate <renovate@ptinem.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #6713
/assign inteon