Graduate 'DisallowInsecureCSRUsageDefinition' to GA

[yj-yoo]

Pull Request Motivation

This feature gate was introduced in #6300 (released in v1.13).
This PR graduates this feature to GA, so the deprecated code can be removed.

Kind

/kind cleanup

Release Note

Graduate the 'DisallowInsecureCSRUsageDefinition' feature gate to GA.

[cert-manager-prow]

Hi @yj-yoo. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[inteon]

Thanks @yj-yoo for your PR.
To remove these functions, we also have to make the feature a GA feature; see

cert-manager/internal/webhook/feature/features.go

Line 94 in a9166a8

DisallowInsecureCSRUsageDefinition: {Default: true, PreRelease: featuregate.Beta},

.
Could you please also update the feature flag in that file from Beta to GA?

[yj-yoo]

Thanks @yj-yoo for your PR. To remove these functions, we also have to make the feature a GA feature; see

cert-manager/internal/webhook/feature/features.go

Line 94 in a9166a8

DisallowInsecureCSRUsageDefinition: {Default: true, PreRelease: featuregate.Beta},

.
Could you please also update the feature flag in that file from Beta to GA?

thank you. I took your advice and pushed again.

[inteon]

/ok-to-test

[yj-yoo]

@inteon The changes were reflected and pushed again.

[inteon]

/test pull-cert-manager-master-make-verify

[inteon]

We can remove the DeprecatedCertificateTemplateFromCertificateRequestAndAllowInsecureCSRUsageDefinition function in a future PR.
/approve
/lgtm

[cert-manager-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [inteon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment