Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: graduate gateway-api to beta and enable by default #6961

Merged
merged 1 commit into from
Apr 26, 2024
Merged

feat: graduate gateway-api to beta and enable by default #6961

merged 1 commit into from
Apr 26, 2024

Conversation

ThatsMrTalbot
Copy link
Contributor

@ThatsMrTalbot ThatsMrTalbot commented Apr 25, 2024 •
edited by inteon

Pull Request Motivation

This PR graduates the GatewayAPI support to BETA:

  • The ExperimentalGatewayAPISupport feature flag is now enabled by default
  • An --enable-gateway-api flag / config file option has been added, this is disabled by default.

Fixes #6882

Kind

Release Note

GatewayAPI support has graduated to Beta. Add the `--enable-gateway-api` flag to enable the integration.

@cert-manager-prow cert-manager-prow bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/api Indicates a PR directly modifies the 'pkg/apis' directory needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2024
inteon
inteon reviewed Apr 25, 2024
View reviewed changes
internal/apis/config/controller/v1alpha1/defaults.go
@@ -213,6 +214,10 @@ func SetDefaults_ControllerConfiguration(obj *v1alpha1.ControllerConfiguration)
obj.EnableCertificateOwnerRef = &defaultEnableCertificateOwnerRef
}

if obj.EnableGatewayAPI == nil {
obj.EnableGatewayAPI = &defaultEnableGatewayAPI
Copy link
Member

@inteon inteon Apr 25, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll have to run make update-config-api-defaults.
Also, if you have some extra time: the diff is currently diffing the strings as byte arrays, it might be better to change that to strings so we have a cleaner output in our error messages: https://prow.infra.cert-manager.io/view/gs/cert-manager-prow-artifacts/pr-logs/pull/cert-manager_cert-manager/6961/pull-cert-manager-master-make-test/1783525250986676224

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run and updated the PR, sounds like a good thing to improve the diff, i'll do it in a different PR though

@ThatsMrTalbot
feat: graduate gateway-api to beta and enable by default
a7f089b 
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
@ThatsMrTalbot ThatsMrTalbot force-pushed the feat/graduate-gateway-api-to-beta branch from 8ad1225 to a7f089b Compare April 25, 2024 16:06
@inteon
Copy link
Member

inteon commented Apr 26, 2024

Thanks for completing this!
I think this PR is exactly what we discussed during the gateway-api feature promotion meeting.
/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2024
@cert-manager-prow cert-manager-prow bot merged commit 4fe2141 into cert-manager:master Apr 26, 2024
6 checks passed
@hawksight hawksight mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How About Graduating the Gateway API Support to GA?
2 participants
@ThatsMrTalbot @inteon