Remove deprecated ParseSubjectStringToRawDERBytes function #6994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and move tests Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
cert-manager-prow
bot
added
release-note
cert-manager-prow
bot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
AdamKorcz
pushed a commit
to google/oss-fuzz
that referenced
this pull request
May 14, 2024
#11928) This function was removed in cert-manager/cert-manager#6994. Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were still some tests that were using this function, I updated the tests to test the underlying function instead.
These tests were also moved to a test file that matches the file in which the functions are defined.
Migration guide:
Use the underlying
UnmarshalSubjectStringToRDNSequence(subject)andMarshalRDNSequenceToRawDERBytes(rdnSequence)functions instead.branched from #6775
Kind
/kind cleanup
Release Note