Add base of issuer-specific validation to certificates at runtime #761
Conversation
jetstack-bot
added
the
release-note
jetstack-bot
added
the
size/L
| IssuerRef: validIssuerRef, | ||
| KeyAlgorithm: v1alpha1.RSAKeyAlgorithm, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Can we add a case for a valid type, but invalid for this issuer? e.g. setting key algorithm to ecdsa
| SecretName: "abc", | ||
| IssuerRef: validIssuerRef, | ||
| }, | ||
| issuer: &v1alpha1.IssuerSpec{}, |
There was a problem hiding this comment.
Why does this test case pass? If the issuer type is not defined in the IssuerSpec, surely NameForIssuer should error with fmt.Errorf("no issuer specified for Issuer '%s/%s'", i.GetObjectMeta().Namespace, i.GetObjectMeta().Name)?
There was a problem hiding this comment.
Ah, that is as part of ValidateCertificateForIssuer and not this function. Perhaps we can add a couple of test cases there too for the case where an unspecified issuer type is used?
There was a problem hiding this comment.
I've updated the test to cover ValidateCertificateForIssuer instead of individual validation tests
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Fixes #735