Wait for ACME Orders to be in 'ready' state before attempting finalization #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
munnerz
force-pushed
the
fix-valid-orders
branch
from
e62a9f2
to
441c22c
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
jetstack-bot
added a commit
that referenced
this pull request
Jul 25, 2018
…lease-0.4 Automated cherry pick of #764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When the new 'ready' state for orders was added, we did not add code into the obtainCertificate function to gate finalising orders with the ACME server until they are in a 'ready' state.
This PR adds a gate to ensure that the order is in a valid state for finalisation.
It may also require us to bump the version of Pebble used in our e2e tests, as the older versions will never set the
statusto 'ready'Which issue this PR fixes: fixes #758
Release note:
/cc @kragniz
@tlycken @damienwebdev