Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RenewBeforeExpiryDuration option to controller context #801

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

munnerz
Copy link
Member

@munnerz munnerz commented Aug 8, 2018

What this PR does / why we need it:

This helps break out the changes in #800

It adds a new RenewBeforeExpiryDuration option to help resolve the issues described there.

Special notes for your reviewer:

This option can in future become the default global option when we support this as a field on the issuer spec.

QUESTION: should this field be called renew-before-expiry-duration? yes (cc @zuzzas)

Release note:

Add renew-before-expiry-duration option to configure how long before expiration a certificate should be attempted to be renewed

/cc @kragniz

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2018
@munnerz munnerz changed the title Add RenewBeforeDuration option to controller context Add RenewBeforeExpiryDuration option to controller context Aug 8, 2018
@munnerz munnerz added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Aug 8, 2018
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit c43e4d7 into cert-manager:master Aug 8, 2018
jetstack-bot added a commit that referenced this pull request Aug 10, 2018
@munnerz munnerz deleted the renew-duration branch January 29, 2019 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants