Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates release to v0.4.0, ready for release #108

Merged
merged 1 commit into from Aug 4, 2022
Merged

Updates release to v0.4.0, ready for release #108

merged 1 commit into from Aug 4, 2022
+6 −6

Conversation

JoshVanL
Copy link
Collaborator

@JoshVanL JoshVanL commented Aug 4, 2022

/hold
Until the other PRs have gone in.

@JoshVanL
Updates release to v0.4.0, ready for release
1479172 
Signed-off-by: joshvanl <me@joshvanl.dev>
@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 4, 2022
SgtCoDFish
SgtCoDFish approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

(In advance of the others merging)

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@JoshVanL
Copy link
Collaborator Author

JoshVanL commented Aug 4, 2022

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@JoshVanL
Copy link
Collaborator Author

JoshVanL commented Aug 4, 2022

/hold cancel

@JoshVanL
Copy link
Collaborator Author

JoshVanL commented Aug 4, 2022

/hold

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@JoshVanL
Copy link
Collaborator Author

JoshVanL commented Aug 4, 2022

/hold cancel

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2022
@jetstack-bot jetstack-bot merged commit ea84b40 into cert-manager:main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshVanL @jetstack-bot @SgtCoDFish