Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: vertical template template uses wrong var name #13

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

ThatsMrTalbot
Copy link
Contributor

No description provided.

Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

(Haven't looked into it much, can review a followup if needed)

@jetstack-bot
Copy link
Contributor

@SgtCoDFish: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm
/approve

(Haven't looked into it much, can review a followup if needed)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish
Copy link
Member

(added labels manually, will raise PR to fix owners file!)

@jetstack-bot jetstack-bot merged commit a50e491 into main Jan 15, 2024
4 checks passed
@SgtCoDFish SgtCoDFish deleted the fix/vertical-template branch January 15, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants