Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use table format for markdown #2

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Use table format for markdown #2

merged 2 commits into from
Jan 9, 2024

Conversation

ThatsMrTalbot
Copy link
Contributor

Table format means contents can be multi-line, this in turn means we can use multi-line code blocks with syntax highlighting

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2024
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jan 9, 2024
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@jetstack-bot
Copy link
Contributor

@inteon: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/approve
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ThatsMrTalbot ThatsMrTalbot merged commit d303a06 into main Jan 9, 2024
1 of 2 checks passed
@inteon inteon deleted the feat/table-format branch March 1, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants