Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate makefiles and CI/CD #221

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Migrate makefiles and CI/CD #221

merged 1 commit into from
Jan 8, 2024

Conversation

inteon
Copy link
Member

@inteon inteon commented Nov 18, 2023 •
edited

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 18, 2023
@jetstack-bot jetstack-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2023
@inteon inteon mentioned this pull request Dec 12, 2023
Open
10 tasks
@inteon inteon force-pushed the cicd branch 3 times, most recently from 0e2ea0b to 5f3b8cd Compare January 6, 2024 15:32
@inteon inteon mentioned this pull request Jan 8, 2024
Merged
@inteon inteon force-pushed the cicd branch 4 times, most recently from 4ff4b8e to 8acb17d Compare January 8, 2024 14:25
SgtCoDFish
SgtCoDFish reviewed Jan 8, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few questions: nothing major, but I'd like to understand more! I don't see any real blockers though.

make/_shared/cert-manager/01_mod.mk Show resolved Hide resolved
make/_shared/tools/00_mod.mk
Comment on lines +47 to +48
# https://github.com/Azure/azure-workload-identity/releases
TOOLS += azwi=v1.2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Where's azwi coming from? I can't see it as currently being a dependency of istio-csr? Same question for vault I think and maybe others.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library is part of the make-file modules, so it shouldn't be used in this project specifically.
That being said, it is also not used in approver-policy (the only other library that uses makefile-modules today), so we actually don't really need it.

deploy/charts/istio-csr/templates/deployment.yaml
@@ -45,7 +45,6 @@ spec:
path: {{ .Values.app.readinessProbe.path }}
initialDelaySeconds: 3
periodSeconds: 7
command: ["cert-manager-istio-csr"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why this change? Does the entrypoint change in the built container?

Copy link
Member Author

@inteon inteon Jan 8, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think the entrypoint changes because we switch to build using ko.

test/carotation/workloads/httpbin.yaml Outdated Show resolved Hide resolved
@inteon
migrate makefiles and CI/CD
39e4051 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon mentioned this pull request Jan 8, 2024
Merged
SgtCoDFish
SgtCoDFish approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

This is clearly reasonable! Thanks for this, I know it's tonnes of work!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2024
@jetstack-bot jetstack-bot merged commit 5696d1d into cert-manager:main Jan 8, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @jetstack-bot @SgtCoDFish