Create a single variables file for cert-manager + Vault workflow

[lonelyCZ]

Signed-off-by: lonelyCZ 531187475@qq.com

Fixes #7

We can configure kubeconfig_path in cm-vault/common.tfvars to apply to all modules.

[lonelyCZ]

/cc @irbekrm

/assign @irbekrm

[irbekrm]

Thanks @lonelyCZ !

This looks good to me 👍🏼

Generally it's not a good practice to commit .tfvars files to Git, but I think in this case it should be ok as this is not intended for production use and also I don't think this will ever contain any secrets.

Small nit: could you please update the Readme to mention the new vars file? Apart from that this looks good to merge 👍🏼

[lonelyCZ]

Generally it's not a good practice to commit .tfvars files to Git, but I think in this case it should be ok as this is not intended for production use and also I don't think this will ever contain any secrets.

Yes, this is also my thinking.

Small nit: could you please update the Readme to mention the new vars file? Apart from that this looks good to merge

I have added it, please review it again.

[lonelyCZ]

/assign @irbekrm

[irbekrm]

Thank you for the quick fix @lonelyCZ !

I think the documentation should be in ./cm-vault/README.md not in ./README.md. Apart from that this looks good to go in!

[lonelyCZ]

/assign @irbekrm

[irbekrm]

Thank you @lonelyCZ !

/lgtm

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [irbekrm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment