-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a single variables file for cert-manager + Vault workflow #12
Conversation
Thanks @lonelyCZ ! This looks good to me 👍🏼 Generally it's not a good practice to commit Small nit: could you please update the Readme to mention the new vars file? Apart from that this looks good to merge 👍🏼 |
Yes, this is also my thinking.
I have added it, please review it again. |
/assign @irbekrm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the quick fix @lonelyCZ !
I think the documentation should be in ./cm-vault/README.md not in ./README.md. Apart from that this looks good to go in!
Signed-off-by: lonelyCZ <531187475@qq.com>
/assign @irbekrm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @lonelyCZ !
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, lonelyCZ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: lonelyCZ 531187475@qq.com
Fixes #7
We can configure
kubeconfig_path
incm-vault/common.tfvars
to apply to all modules.