Allow to optionally use AppRole to authenticate with Vault

[lonelyCZ]

Signed-off-by: lonelyCZ 531187475@qq.com

Fixes #18

[lonelyCZ]

Hi @irbekrm , thanks for your suggestions, I have added this feature.

/assign @irbekrm

[lonelyCZ]

/hold

I will rebase this pr firstly.

[lonelyCZ]

/unhold

[lonelyCZ]

PTAL

/cc @irbekrm

[irbekrm]

Thank you @lonelyCZ this is really good work 👍🏼

I have tested it with both authentication methods and everything worked as expected.

I have added a couple suggestions.
I think also we want to update the Readme in ./cm-vault with the available auth methods and update other details there like ClusterIssuer name etc. I also see that the Readme has out-of-date info about configuring port-forward in the kind cluster.

Apart from that, this looks good to go in, again great work!

[lonelyCZ]

Thanks for your suggestion. I have updated it.

I think also we want to update the Readme in ./cm-vault with the available auth methods and update other details there like ClusterIssuer name etc. I also see that the Readme has out-of-date info about configuring port-forward in the kind cluster.

Thanks for pointing out. I will update the README in next pr.

[irbekrm]

Thanks @lonelyCZ !

This now looks good to me. Would be good to update Readme next, really it should be done at the same time as the change is added to code as else the Readme stays incorrect.

/lgtm
/approve

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [irbekrm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lonelyCZ]

Would be good to update Readme next, really it should be done at the same time as the change is added to code as else the Readme stays incorrect.

I see, thanks, I will do it in future.