Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass configure Helm values for cert-manager installation #32

Merged
merged 1 commit into from Aug 8, 2022

Conversation

lonelyCZ
Copy link
Contributor

@lonelyCZ lonelyCZ commented Aug 7, 2022

Signed-off-by: lonelyCZ <531187475@qq.com>
@lonelyCZ
Copy link
Contributor Author

lonelyCZ commented Aug 8, 2022

/assign @irbekrm

Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lonelyCZ !

I've tested this and works as expected 👍🏼 good work.

/lgtm

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit bcf5ef6 into cert-manager:master Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to pass configure Helm values for cert-manager installation
3 participants