Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Ingress support to configurate an ACME issuer #40

Merged
merged 2 commits into from Sep 7, 2022

Conversation

lonelyCZ
Copy link
Contributor

@lonelyCZ lonelyCZ commented Sep 4, 2022

Fixes #39

Signed-off-by: lonelyCZ <531187475@qq.com>
Signed-off-by: lonelyCZ <531187475@qq.com>
@lonelyCZ
Copy link
Contributor Author

lonelyCZ commented Sep 4, 2022

/assign @irbekrm

Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lonelyCZ this is really good work.

I have tested this on a GKE cluster by pre-creating a static IP address and passing it as controller.service.loadBalancerIP as well as setting up DNS and passing a custom hostname and email- the Certificate became ready and I verified that the ingress backend is configured with the newly issued cert:

irbe@testing-addons$ k get cert,cr -A
NAMESPACE      NAME                                            READY   SECRET              AGE
ingress-demo   certificate.cert-manager.io/ingress-test-cert   True    ingress-test-cert   16m

NAMESPACE      NAME                                                         APPROVED   DENIED   READY   ISSUER           REQUESTOR                                         AGE
ingress-demo   certificaterequest.cert-manager.io/ingress-test-cert-fxcwg   True                True    ingress-issuer   system:serviceaccount:cert-manager:cert-manager   16m
irbe@cm-ingress$ kubectl ingress-nginx certs --host <redacted-hostname> -n ingress-nginx | openssl x509 -text -noout | grep Issuer
        Issuer: C = US, O = (STAGING) Let's Encrypt, CN = (STAGING) Artificial Apricot R3
                CA Issuers - URI:http://stg-r3.i.lencr.org/

Again, great work and thanks for updating the Readme!

/lgtm

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 369ebf9 into cert-manager:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the Ingress support to configurate an ACME issuer
3 participants