Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Readme to introduce this repository #5

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

lonelyCZ
Copy link
Contributor

Signed-off-by: lonelyCZ 531187475@qq.com

Fixes #1

Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lonelyCZ !

This all looks good to me, except for I think that we should not add a section on Vault yet as it is not yet in the repository.

README.md Outdated
export TF_PLUGIN_CACHE_DIR="$HOME/.terraform.d/plugin-cache"
```

## Usage Steps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: remove this part as at the moment we do not actually have that funcitonality in this repository.

That can be added together with the PR that actually adds Vault I think.

Signed-off-by: lonelyCZ <531187475@qq.com>
@lonelyCZ
Copy link
Contributor Author

I will fill this readme one by one in next PRs.

/cc @irbekrm

@irbekrm
Copy link
Contributor

irbekrm commented Jun 16, 2022

Thank you @lonelyCZ !

Nice to get the first PR merged 🥳

/lgtm
/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, lonelyCZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit a552ff9 into cert-manager:master Jun 16, 2022
@lonelyCZ lonelyCZ deleted the pr-add-readme branch July 26, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Readme
3 participants