Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing the aws periodic job and adding a presubmit job #546

Merged
merged 3 commits into from
Aug 10, 2021
Merged

fixing the aws periodic job and adding a presubmit job #546

merged 3 commits into from
Aug 10, 2021

Conversation

RinkiyaKeDad
Copy link
Contributor

No description provided.

@RinkiyaKeDad
fix periodic job and add presubmit job
6105338 
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
@RinkiyaKeDad
add newline
548dc72 
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. area/cert-manager Indicates a PR related to cert-manager labels Aug 10, 2021
@jetstack-bot
Copy link
Contributor

Hi @RinkiyaKeDad. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 10, 2021
jakexks
jakexks requested changes Aug 10, 2021
View reviewed changes
config/jobs/cert-manager/cert-manager-periodics.yaml Outdated
@@ -512,7 +512,7 @@ periodics:
containers:
- image: eu.gcr.io/jetstack-build-infra-images/golang-aws@sha256:1f330e4c9552ca383d157067b73fb0e090b64b0777939fd59e58b60e06020d66
args:
- -c
- bash -c
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash and -c have to be separate times in the list

Suggested change
- bash -c
- bash
- -c

@RinkiyaKeDad
bash and c on separate lines
cba40f7 
Signed-off-by: Arsh Sharma <arshsharma461@gmail.com>
@RinkiyaKeDad
Copy link
Contributor Author

@jakexks made the changes, PTAL :)

jakexks
jakexks approved these changes Aug 10, 2021
View reviewed changes
Copy link
Member

@jakexks jakexks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 10, 2021
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, RinkiyaKeDad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2021
@jakexks
Copy link
Member

jakexks commented Aug 10, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2021
@RinkiyaKeDad
Copy link
Contributor Author

/release-note-none

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 10, 2021
@jakexks jakexks merged commit 143a138 into cert-manager:master Aug 10, 2021
@jetstack-bot
Copy link
Contributor

@RinkiyaKeDad: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-periodics.yaml using file config/jobs/cert-manager/cert-manager-periodics.yaml
  • key cert-manager-presubmits.yaml using file config/jobs/cert-manager/cert-manager-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakexks jakexks jakexks approved these changes

Assignees

@jakexks jakexks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RinkiyaKeDad @jetstack-bot @jakexks