-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the branches list #628
Conversation
For consistency with other cert-manager jobs. Signed-off-by: Richard Wall <richard.wall@jetstack.io>
/override pull-testing-check-testgrid-config |
@wallrj: wallrj unauthorized: /override is restricted to Repo administrators. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override pull-testing-check-testgrid-config |
@BeckyPauley: Overrode contexts on behalf of BeckyPauley: pull-testing-check-testgrid-config In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irbekrm, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@wallrj: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Ostensibly for consistency with other cert-manager jobs, e.g.
https://github.com/jetstack/testing/blob/d903cb91142155db80ab23b3f36afdae11331aed/config/jobs/cert-manager/csi-lib/cert-manager-csi-lib-presubmits.yaml#L10-L11
But really this is a pointless and hopefully non-breaking change designed to trigger the config-updater plugin to redeploy the job-config.
It failed to do so for #625.
It may even be worse, since the branches are supposed to be a Regexp, but it's not clear from the docs whether they are a regexp match or a search: