Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the branches list #628

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Conversation

wallrj
Copy link
Member

@wallrj wallrj commented Feb 9, 2022

Ostensibly for consistency with other cert-manager jobs, e.g.

https://github.com/jetstack/testing/blob/d903cb91142155db80ab23b3f36afdae11331aed/config/jobs/cert-manager/csi-lib/cert-manager-csi-lib-presubmits.yaml#L10-L11

But really this is a pointless and hopefully non-breaking change designed to trigger the config-updater plugin to redeploy the job-config.
It failed to do so for #625.

It may even be worse, since the branches are supposed to be a Regexp, but it's not clear from the docs whether they are a regexp match or a search:

For consistency with other cert-manager jobs.

Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj requested a review from irbekrm February 9, 2022 13:20
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/cert-manager Indicates a PR related to cert-manager approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2022
@wallrj
Copy link
Member Author

wallrj commented Feb 10, 2022

/override pull-testing-check-testgrid-config

@jetstack-bot
Copy link
Contributor

@wallrj: wallrj unauthorized: /override is restricted to Repo administrators.

In response to this:

/override pull-testing-check-testgrid-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BeckyPauley
Copy link
Contributor

/override pull-testing-check-testgrid-config

@jetstack-bot
Copy link
Contributor

@BeckyPauley: Overrode contexts on behalf of BeckyPauley: pull-testing-check-testgrid-config

In response to this:

/override pull-testing-check-testgrid-config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@irbekrm irbekrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 10, 2022
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit b6d85d9 into cert-manager:master Feb 10, 2022
@jetstack-bot
Copy link
Contributor

@wallrj: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-webhook-example-presubmits.yaml using file config/jobs/cert-manager/webhook-example/cert-manager-webhook-example-presubmits.yaml

In response to this:

Ostensibly for consistency with other cert-manager jobs, e.g.

https://github.com/jetstack/testing/blob/d903cb91142155db80ab23b3f36afdae11331aed/config/jobs/cert-manager/csi-lib/cert-manager-csi-lib-presubmits.yaml#L10-L11

But really this is a pointless and hopefully non-breaking change designed to trigger the config-updater plugin to redeploy the job-config.
It failed to do so for #625.

It may even be worse, since the branches are supposed to be a Regexp, but it's not clear from the docs whether they are a regexp match or a search:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj deleted the webhook-config branch February 10, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cert-manager Indicates a PR related to cert-manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants