Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional resources block for init container #295

Closed
wants to merge 1 commit into from

Conversation

niklastanner
Copy link

Add optional resources block for the init container of the default package.

@jetstack-bot jetstack-bot added the dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. label Feb 16, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign erikgb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 16, 2024
@jetstack-bot
Copy link
Contributor

Hi @niklastanner. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 16, 2024
…s Tanner <niklas.tanner@hotmail.com>

Signed-off-by: ner <Niklas.Tanner@ti8m.ch>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Feb 16, 2024
@SgtCoDFish
Copy link
Member

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 5, 2024
@SgtCoDFish
Copy link
Member

/test pull-trust-manager-verify

(pod was killed during the test I think)

@SgtCoDFish
Copy link
Member

Hey @niklastanner thanks for raising this (and sorry it took a while to look into)! It looks like your PR is falling foul of the new values schema that was added. Are you able to also update the schema?

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Mar 5, 2024
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 5, 2024
@jetstack-bot
Copy link
Contributor

@niklastanner: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-trust-manager-verify 0106255 link true /test pull-trust-manager-verify
pull-trust-manager-smoke 0106255 link true /test pull-trust-manager-smoke

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@niklastanner
Copy link
Author

@SgtCoDFish What do you mean by "update the schema"? It's the exact same schema already used by the main image. Building the template locally using helm template does generate a valid YAML file.

@SgtCoDFish
Copy link
Member

My apologies - it looks like running make generate will solve the issue. I think the tests hiccuped when I looked - sorry!

@SgtCoDFish
Copy link
Member

@niklastanner Are you able to run make generate locally quickly and commit the result? I might be able to squeeze this into the next trust-manager release this week if we're super quick

jetstack-bot added a commit that referenced this pull request Mar 6, 2024
initContainer Resource Block: Fix #295 for merging
@SgtCoDFish
Copy link
Member

@niklastanner I went ahead and did make generate in #316 just so we could include this in trust-manager v0.9.0

Thank you for your contribution, really appreciate you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants