New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional resources block for init container #295
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @niklastanner. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…s Tanner <niklas.tanner@hotmail.com> Signed-off-by: ner <Niklas.Tanner@ti8m.ch>
/ok-to-test |
/test pull-trust-manager-verify (pod was killed during the test I think) |
Hey @niklastanner thanks for raising this (and sorry it took a while to look into)! It looks like your PR is falling foul of the new values schema that was added. Are you able to also update the schema? |
@niklastanner: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@SgtCoDFish What do you mean by "update the schema"? It's the exact same schema already used by the main image. Building the template locally using |
My apologies - it looks like running |
@niklastanner Are you able to run |
initContainer Resource Block: Fix #295 for merging
@niklastanner I went ahead and did Thank you for your contribution, really appreciate you! |
Add optional resources block for the init container of the default package.