initContainer Resource Block: Fix #295 for merging #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s Tanner <niklas.tanner@hotmail.com> Signed-off-by: ner <Niklas.Tanner@ti8m.ch>
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
added
dco-signoff: yes
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
wallrj
reviewed
Mar 6, 2024
There was a problem hiding this comment.
I tested it locally and it seems to work:
$ kubectl describe pod trust-manager-54c7cdf496-qlnjl
Name: trust-manager-54c7cdf496-qlnjl
Namespace: default
Priority: 0
Service Account: trust-manager
Node: kind-control-plane/172.18.0.2
Start Time: Wed, 06 Mar 2024 15:25:29 +0000
Labels: app=trust-manager
app.kubernetes.io/instance=tm
app.kubernetes.io/managed-by=Helm
app.kubernetes.io/name=trust-manager
app.kubernetes.io/version=v0.8.0
helm.sh/chart=trust-manager-v0.8.0
pod-template-hash=54c7cdf496
Annotations: <none>
Status: Pending
IP:
IPs: <none>
Controlled By: ReplicaSet/trust-manager-54c7cdf496
Init Containers:
cert-manager-package-debian:
Container ID:
Image: quay.io/jetstack/cert-manager-package-debian:20210119.0
Image ID:
Port: <none>
Host Port: <none>
SeccompProfile: RuntimeDefault
Args:
/copyandmaybepause
/debian-package
/packages
State: Waiting
Reason: PodInitializing
Ready: False
Restart Count: 0
Limits:
cpu: 100m
memory: 128Mi
Requests:
cpu: 100m
memory: 128Mi
Environment: <none>
Mounts:
/packages from packages (rw)
/var/run/secrets/kubernetes.io/serviceaccount from kube-api-access-nw5h7 (ro)/lgtm
/approve
| @@ -53,6 +53,17 @@ image: | |||
| defaultPackage: | |||
| # Whether to load the default trust package during pod initialization, and include it in main container args. This container enables the 'useDefaultCAs' source on Bundles. | |||
| enabled: true | |||
| # Kubernetes pod resource limits for default package init container. | |||
There was a problem hiding this comment.
Suggested change
| # Kubernetes pod resource limits for default package init container. | |
| # Kubernetes Pod resource requests and limits for the default trust package init container. |
The original text matches the documentation for the existing resources value, so happy if you prefer to keep it as-is for consistency
trust-manager/deploy/charts/trust-manager/values.yaml
Lines 106 to 116 in f728840
|
Ah, too late! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #295 so we can merge it ahead of a release. I cherry-picked the commit from #295 so that @niklastanner would still get credit for their contribution.
Since I want to release soon, I'm cherry-picking and fixing in my own PR so that we can move quickly!