New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Configurable Common Labels and Add a PDB #149
Conversation
Hi @justdan96. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I will have to add the DCO sign off to the previous commits this evening. |
@jakexks are you able to review if this PR is okay to test? |
Signed-off-by: Dan Bryant <daniel.bryant@linux.com>
Thanks @justdan96, I rebased your PR and updated the PDB to match the logic and comments in cert-manager. |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
These changes to the Helm chart are really to introduce two changes:
commonLabels
value, which adds the user-supplied extra labels to all Trust Manager resources including thetrust-manager
pods.Most of the code is just copy-and-paste from Cert-Manager's Helm chart.