Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configurable Common Labels and Add a PDB #149

Merged
merged 1 commit into from Feb 26, 2024

Conversation

justdan96
Copy link
Contributor

These changes to the Helm chart are really to introduce two changes:

  1. Add a configurable commonLabels value, which adds the user-supplied extra labels to all Trust Manager resources including the trust-manager pods.
  2. Add a configurable PodDisruptionBudget.

Most of the code is just copy-and-paste from Cert-Manager's Helm chart.

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2023
@jetstack-bot
Copy link
Contributor

Hi @justdan96. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 10, 2023
@justdan96
Copy link
Contributor Author

I will have to add the DCO sign off to the previous commits this evening.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jul 11, 2023
@justdan96
Copy link
Contributor Author

@jakexks are you able to review if this PR is okay to test?

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 17, 2023
@inteon inteon self-assigned this Feb 26, 2024
Signed-off-by: Dan Bryant <daniel.bryant@linux.com>
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2024
@inteon
Copy link
Member

inteon commented Feb 26, 2024

Thanks @justdan96, I rebased your PR and updated the PDB to match the logic and comments in cert-manager.
/approve
/lgtm

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2024
@inteon
Copy link
Member

inteon commented Feb 26, 2024

/retest

@inteon
Copy link
Member

inteon commented Feb 26, 2024

/approve
/lgtm

@jetstack-bot jetstack-bot merged commit caad594 into cert-manager:main Feb 26, 2024
4 checks passed
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants