Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new optional registry and digest Helm values #154

Merged

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jul 29, 2023

Fixes #148

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2023
@jetstack-bot
Copy link
Contributor

Hi @erikgb. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 29, 2023
@erikgb erikgb force-pushed the issue-148-helm-chart-image-values branch from 0e8be60 to 70a5cb9 Compare August 24, 2023 19:45
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@JoshVanL
Copy link
Contributor

Cheers!
/lgtm
/approve
/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 24, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2023
@JoshVanL
Copy link
Contributor

@erikgb looks like it needs a make helms doc update

@erikgb erikgb force-pushed the issue-148-helm-chart-image-values branch from 70a5cb9 to ee34b8f Compare August 25, 2023 06:00
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@erikgb
Copy link
Contributor Author

erikgb commented Aug 25, 2023

@JoshVanL Thanks, done now. I think I need to apply for a cert-manager org membership - to avoid waiting for the ok-test-label. PTAL

@erikgb erikgb force-pushed the issue-148-helm-chart-image-values branch from ee34b8f to 38789e5 Compare August 25, 2023 06:17
@inteon
Copy link
Member

inteon commented Aug 25, 2023

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@jetstack-bot jetstack-bot merged commit 53076d8 into cert-manager:main Aug 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image registry and repository separation
4 participants