-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CM binary data reconcile preparing for PKCS#12 support #162
Conversation
Hi @erikgb. Thanks for your PR. I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
28a966e
to
15511a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
15511a8
to
dc90f52
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
dc90f52
to
42b74c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Private interface refactor with passing tests so lgtm
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb, jakexks The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before filing a PR to add support for PKCS#12 truststores (ref. remaining in #17), I think it makes sense to slightly refactor the JKS truststore support introduced in #122. I think it will make the follow-up PR easier to review.