Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter resources triggered by namespace #169

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Filter resources triggered by namespace #169

merged 1 commit into from
Aug 31, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Aug 30, 2023

When a namespace changes, we only want to re-reconcile all bundles that have that namespace as a target.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 30, 2023
@inteon
Copy link
Member Author

inteon commented Aug 30, 2023

/retest

erikgb
erikgb reviewed Aug 30, 2023
View reviewed changes
pkg/bundle/bundle.go Outdated Show resolved Hide resolved
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 31, 2023
@inteon inteon closed this Aug 31, 2023
@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 31, 2023
@inteon
filter resources triggered by namespace
3bd6392 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@inteon inteon reopened this Aug 31, 2023
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2023
@cert-manager cert-manager deleted a comment from jetstack-bot Aug 31, 2023
@cert-manager cert-manager deleted a comment from jetstack-bot Aug 31, 2023
@inteon
Copy link
Member Author

inteon commented Aug 31, 2023

/test pull-trust-manager-verify

erikgb
erikgb approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@inteon
Copy link
Member Author

inteon commented Aug 31, 2023

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2023
@jetstack-bot jetstack-bot merged commit 6639515 into cert-manager:main Aug 31, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @jetstack-bot @erikgb