Allow user to specify the name of cert-manager's ServiceAccount #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
SgtCoDFish
force-pushed
the
cert-manager-sa
branch
from
eae0d7a
to
3eff9f9
Compare
jetstack-bot
added
size/S
erikgb
reviewed
Sep 5, 2023
| @@ -78,7 +78,10 @@ app: | |||
| # -- Whether to create an approver-policy CertificateRequestPolicy allowing auto-approval of the trust-manager webhook certificate. If you have approver-policy installed, you almost certainly want to enable this. | |||
| enabled: false | |||
|
|
|||
| # -- Namespace in which cert-manager was installed. Only used if approverPolicy has been enabled. | |||
| # -- Name of cert-manager's ServiceAccount. Only used if app.webhook.tls.approverPolicy.enabled is true | |||
| certManagerServiceAccount: "cert-manager" | |||
There was a problem hiding this comment.
Nit: Maybe put this value below the certManagerNamespace value? Seems more conceptually correct to me. 😉
SgtCoDFish
force-pushed
the
cert-manager-sa
branch
from
3eff9f9
to
8d68358
Compare
|
/test pull-trust-manager-verify |
2 similar comments
|
/test pull-trust-manager-verify |
|
/test pull-trust-manager-verify |
The cert-manager ServiceAccount is not fixed and so can vary between different installations. [1] [2] cert-manager users might well want to customise it, and we should support those users in trust-manager! [1] https://github.com/cert-manager/cert-manager/blob/cab2b3b68ca834b60931fd76d1fb74f757a03550/deploy/charts/cert-manager/templates/serviceaccount.yaml#L10 [2] https://github.com/cert-manager/cert-manager/blob/cab2b3b68ca834b60931fd76d1fb74f757a03550/deploy/charts/cert-manager/values.yaml#L108 Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
CRPs are cluster scoped so the namespace here is ignored Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
SgtCoDFish
force-pushed
the
cert-manager-sa
branch
from
8d68358
to
3ef4c77
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cert-manager ServiceAccount is not fixed and so can vary between different installations. [1] [2]
cert-manager users might well want to customise it, and we should support those users in trust-manager!
ℹ️ This also removes the namespace from the CertificateRequestPolicy, since that resource is cluster scoped and so passing a namespace here is a no-op!
[1] https://github.com/cert-manager/cert-manager/blob/cab2b3b68ca834b60931fd76d1fb74f757a03550/deploy/charts/cert-manager/templates/serviceaccount.yaml#L10
[2] https://github.com/cert-manager/cert-manager/blob/cab2b3b68ca834b60931fd76d1fb74f757a03550/deploy/charts/cert-manager/values.yaml#L108