Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update a couple of instances of the old project name #192

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Update a couple of instances of the old project name #192

merged 2 commits into from
Oct 9, 2023

Conversation

SgtCoDFish
Copy link
Member

Spotted these while working on something unrelated and couldn't help but shave the yak!

@SgtCoDFish
update a couple of instances of the old project name
2ca74d9 
Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 6, 2023
erikgb
erikgb approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retest

Thanks Ash! 😊

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 6, 2023
@erikgb
Copy link
Contributor

erikgb commented Oct 6, 2023

It seems like the Helm docs are not 100% up-to-date.

Please run 'make -s update-helm-docs'

@inteon inteon self-assigned this Oct 9, 2023
@inteon
run 'make update-helm-docs'
53465e4 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@inteon
Copy link
Member

inteon commented Oct 9, 2023

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2023
@inteon
Copy link
Member

inteon commented Oct 9, 2023

/retest

1 similar comment
@inteon
Copy link
Member

inteon commented Oct 9, 2023

/retest

@inteon
Copy link
Member

inteon commented Oct 9, 2023

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 9, 2023
@jetstack-bot jetstack-bot merged commit 2f328d2 into cert-manager:main Oct 9, 2023
4 checks passed
@SgtCoDFish
Copy link
Member Author

The problem with this one is that my local update-helm-docs is producing exactly the file as committed, while the CI check is producing a different file. Looking into why, but it's also clear that the way helm-docs is vendored locally is problematic and needs updating

@inteon
Copy link
Member

inteon commented Oct 9, 2023

@SgtCoDFish I think you have an old dependency version, try removing your cached downloaded dependency binaries.

@SgtCoDFish
Copy link
Member Author

@SgtCoDFish I think you have an old dependency version, try removing your cached downloaded dependency binaries.

I know, I'm updating it so that it doesn't happen to anyone else!

@SgtCoDFish
Copy link
Member Author

how has this merged with failing tests!? 😢

@erikgb
Copy link
Contributor

erikgb commented Oct 9, 2023

@SgtCoDFish I think you have an old dependency version, try removing your cached downloaded dependency binaries.

Is there any way to make Go detect this outdated situation?

@SgtCoDFish
Copy link
Member Author

Is there any way to make Go detect this outdated situation?

It's a problem with the makefile really, I'm gonna raise a PR which fixes it!

@SgtCoDFish SgtCoDFish deleted the tmrename branch October 9, 2023 14:56
@SgtCoDFish SgtCoDFish mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb approved these changes

Assignees

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SgtCoDFish @erikgb @inteon @jetstack-bot