Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow setting namespace for helm chart #198

Merged
merged 1 commit into from
Oct 17, 2023
Merged

allow setting namespace for helm chart #198

merged 1 commit into from
Oct 17, 2023

Conversation

vinny-sabatini
Copy link
Contributor

@vinny-sabatini vinny-sabatini commented Oct 15, 2023 •
edited

This is based on cert-manager's helm chart override and resolves #145

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2023
@jetstack-bot
Copy link
Contributor

Hi @vinny-sabatini. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 15, 2023
@vinny-sabatini
Copy link
Contributor Author

vinny-sabatini commented Oct 15, 2023 •
edited

This addresses #198

@erikgb
Copy link
Contributor

erikgb commented Oct 16, 2023

This addresses #198

@vinny-sabatini, thanks for looking into this. I believe this PR should resolve #145? Can you please add a proper description to the PR?

@vinny-sabatini
Copy link
Contributor Author

@vinny-sabatini, thanks for looking into this. I believe this PR should resolve #145? Can you please add a proper description to the PR?

Whoops, wrong link 😅 thanks @erikgb ! I have updated the description on the PR.

erikgb
erikgb suggested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM. Thanks for the description with the correct link.

deploy/charts/trust-manager/README.md Outdated Show resolved Hide resolved
@vinny-sabatini
allow setting namespace for helm chart
98cdbd3 
Signed-off-by: Vincent Sabatini <vincent.sabatini@gmail.com>
erikgb
erikgb approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2023
@erikgb
Copy link
Contributor

erikgb commented Oct 17, 2023

/retest

@erikgb
Copy link
Contributor

erikgb commented Oct 17, 2023

/assign @SgtCoDFish @inteon

SgtCoDFish
SgtCoDFish approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Love it, thank you Vinny for fixing and Erik for reviewing 😁

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2023
@jetstack-bot jetstack-bot merged commit a945824 into cert-manager:main Oct 17, 2023
3 of 4 checks passed
@vinny-sabatini vinny-sabatini deleted the issue-145 branch October 17, 2023 14:09
This was referenced Oct 27, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb approved these changes

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

@inteon inteon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Override namespace installation
5 participants
@vinny-sabatini @jetstack-bot @erikgb @SgtCoDFish @inteon