Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade go to 1.21 #204

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Upgrade go to 1.21 #204

merged 1 commit into from
Oct 20, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Oct 20, 2023 •
edited

Upgrade all go versions & go.mod files to 1.21

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2023
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2023
SgtCoDFish
SgtCoDFish requested changes Oct 20, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
hack/tools/go.mod Outdated Show resolved Hide resolved
trust-packages/debian/go.mod Outdated Show resolved Hide resolved
erikgb
erikgb reviewed Oct 20, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@inteon
upgrade go to 1.21
c86ef6e 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
erikgb
erikgb approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

But we might consider requiring just 1.21.0 in the go.mod files. Do we plan to bump the requirement as new Go releases are released?

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2023
@inteon
Copy link
Member Author

inteon commented Oct 20, 2023 •
edited

I don't think we have to bump it every time, I just did it now because in 1.21 the go.sum files contain more entries (I think they were missing in 1.20).

So 1.21.0 would work too.

@inteon
Copy link
Member Author

inteon commented Oct 20, 2023

/approve

@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023
@jetstack-bot jetstack-bot merged commit c48304d into cert-manager:main Oct 20, 2023
4 checks passed
@SgtCoDFish
Copy link
Member

Closing the loop: https://go.dev/ref/mod#go-mod-file-go

The go directive is specifying a minimum. The fact that it's an older version here isn't a problem really!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish requested changes

@erikgb erikgb erikgb approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@inteon @jetstack-bot @SgtCoDFish @erikgb