Remove patch versions from go directives #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps older versions of go parse these directives Specifically, our build process for the default trust package locally depends on trust-manager@main, but older releases (the release-0.6 branch) use go 1.20 and won't be able to parse them. This tangle isn't ideal, but for future versions (i.e. when we can retire the release-0.6 branch and all supported versions use go 1.21) we can move past this and add the patch releases to our go directives again. Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
added
dco-signoff: yes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps older versions of go parse these directives
Specifically, our build process for the default trust package locally depends on trust-manager@main, but older releases (the release-0.6 branch) use go 1.20 and won't be able to parse them.
This tangle isn't ideal, but for future versions (i.e. when we can retire the release-0.6 branch and all supported versions use go 1.21) we can move past this and add the patch releases to our go directives again.
Motivation: This test failure for the release-0.6 branch. Specifically: