Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup patch functions Secret and ConfigMap targets #210

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Cleanup patch functions Secret and ConfigMap targets #210

merged 2 commits into from
Oct 25, 2023

Conversation

inteon
Copy link
Member

@inteon inteon commented Oct 25, 2023 •
edited

Renamed some functions and removed some unnecessary type casting.

@inteon
cleanup patch functions Secret and ConfigMap targets
6dcf5e0 
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 25, 2023
@inteon
Copy link
Member Author

inteon commented Oct 25, 2023

/test pull-trust-manager-verify

@erikgb
Copy link
Contributor

erikgb commented Oct 25, 2023

Thanks Tim!

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
erikgb
erikgb reviewed Oct 25, 2023
View reviewed changes
pkg/bundle/sync.go Outdated Show resolved Hide resolved
@inteon @erikgb
Update pkg/bundle/sync.go
0f1a2a3 
Co-authored-by: Erik Godding Boye <egboye@gmail.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@inteon
Copy link
Member Author

inteon commented Oct 25, 2023

/approve

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@inteon
Copy link
Member Author

inteon commented Oct 25, 2023

/test pull-trust-manager-smoke

@inteon inteon requested a review from erikgb October 25, 2023 08:28
erikgb
erikgb approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit 58df5a6 into cert-manager:main Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb approved these changes

@SgtCoDFish SgtCoDFish Awaiting requested review from SgtCoDFish

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inteon @erikgb @jetstack-bot