Allow permissions to put the leases in the trust-manager namespace, not the trust namespace

[tspearconquest]

This pull request separates the lease permissions to their own role and role binding in the namespace where trust-manager will be installed. See #224 for more details.

[jetstack-bot]

Hi @tspearconquest. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[erikgb]

/ok-to-test

[erikgb]

Thanks @tspearconquest. I think we should do this, but it probably deserves special attention in the release notes for our next release. As we change namespace of the leader election lease for some users, that might allow multiple trust-manager controllers to run for a short while.

[tspearconquest]

Sounds good. Is there anything I need to do in order to mention this in the release notes, or will it be taken care of in the release?

[erikgb]

/lgtm

[erikgb]

/cc @wallrj @SgtCoDFish @inteon

I am tempted to approve this as well, but since my approver status is very fresh, I don't want to do anything wrong. 👼

[SgtCoDFish]

/lgtm
/approve

Thanks for this - it makes sense to me. Really appreciate your involvement 😁

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[erikgb]

/cherrypick release-0.7

[jetstack-bot]

@erikgb: new pull request created: #263

In response to this:

/cherrypick release-0.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.