Fix apply configuration generation on macOS #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On at least macos 14.1 (sonoma) the paste utility seems to require a filename to be specified; before this change, the API_DIRS command fails with the following error: > usage: paste [-s] [-d delimiters] file ... Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
This avoids us spinning up a separate shell when we can use the existing identical value This change also changes the variable assignments; make variables are very confusing, but := should only evaluate at startup while = will evaluate every time the variable is used Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
added
dco-signoff: yes
|
Thanks Ash! I am just dreaming of a Mac! 😉 I have also verified that this still works on my Windows-Ubuntu. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while looking into #240
Commit 1
On at least macos 14.1 (sonoma) the paste utility seems to require a filename to be specified; before this change, the
API_DIRSvariable fails with the following error:Commit 2
This avoids us spinning up a separate shell when evaluating
API_DIRS, sinceGO_MODULEalready contains the value we want.This change also changes the variable assignments; make variables are very confusing, but
:=should only evaluate at startup while=will evaluate every time the variable is used.See these docs for how
=works, and these for:=. From the first link: