test: fix flaky tests by introducing komega

[erikgb]

This change will hopefully fix the flaky integration tests that have been annoying me in several PRs. I like Ginkgo/Gomega, but I know the maintainers are not big fans. 😁 But as long as we are using Ginkgo/Gomega, I think komega (part of controller-runtime) makes the code more compact and avoids attempts on outdated test resource updates.

/cc @inteon @SgtCoDFish

[inteon]

/test pull-trust-manager-smoke

[SgtCoDFish]

/lgtm
/approve

I wasn't aware of komega but it definitely looks like it makes things simpler! Even if this doesn't fix flakes I feel like it makes things easier to reason about.

I like Ginkgo/Gomega, but I know the maintainers are not big fans.

I should expand on this: I feel personally that these tools make the tests harder to understand. I've also been burned by the big changes introduced in Ginkgo v2 which meant we had (and have) to do lots of work to port to the new test format.

Specifically, the flakiness of these tests could be caused by many things but I find the flow so confusing with ginkgo that I can't be sure of where the issue is actually introduced.

I'd prefer plain old go tests - I've never really felt like ginkgo adds much for me personally. But if we can get these tests to be non-flaky with ginkgo, I see no reason to rush to move away from it!

[jetstack-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [SgtCoDFish]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[erikgb]

/cherrypick release-0.7

Required to cherry-pick #260.

[jetstack-bot]

@erikgb: #252 failed to apply on top of branch "release-0.7":

Applying: test: fix flaky tests by introducing komega
Using index info to reconstruct a base tree...
M	test/integration/bundle/suite.go
Falling back to patching base and 3-way merge...
Auto-merging test/integration/bundle/suite.go
CONFLICT (content): Merge conflict in test/integration/bundle/suite.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test: fix flaky tests by introducing komega
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-0.7

Required to cherry-pick #260.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[erikgb]

Created manual cherry-pick PR: #264