Don't build trust bundle images using make image #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`make image` is not as well defined as `make trust-package-debian-save` or `make trust-manager-load`, but it seems reasonable to have it available as a test when developing trust-manager. If `make image` also applies to the trust package, it requires that users come up with a value for `DEBIAN_TRUST_PACKAGE_VERSION` which most users won't be able to guess. Most users should be using the provided commands for loading trust-manager into a kind cluster when developing, which sidesteps this problem entirely. It feels like the simplest thing here is to have `make image` be an alias for `make trust-manager-save`. Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
added
dco-signoff: yes
hawksight
approved these changes
Jan 9, 2024
|
@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hawksight, inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make imageis not as well defined asmake trust-package-debian-saveormake trust-manager-load, but it seems reasonable to have it available as a test when developing trust-manager.If
make imagealso applies to the trust package, it requires that users come up with a value forDEBIAN_TRUST_PACKAGE_VERSIONwhich most users won't be able to guess.Most users should be using the provided commands for loading trust-manager into a kind cluster when developing, which sidesteps this problem entirely.
It feels like the simplest thing here is to have
make imagebe an alias formake trust-manager-save.