Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump toolchain to latest to address CVE-2024-24783 #318

Merged
merged 1 commit into from Mar 6, 2024

Conversation

SgtCoDFish
Copy link
Member

@SgtCoDFish SgtCoDFish commented Mar 6, 2024

We should build with 1.22.1 for a release since we use the 1.22 tag:

FROM --platform=$BUILDPLATFORM docker.io/library/golang:1.22 as builder

This will ensure we're using the 1.22.1 toolchain though!

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 6, 2024
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@SgtCoDFish
Copy link
Member Author

/test pull-trust-manager-smoke

Pod was evicted during the test

@jetstack-bot jetstack-bot merged commit 1427bc6 into cert-manager:main Mar 6, 2024
4 checks passed
@SgtCoDFish SgtCoDFish deleted the bump1.22.1 branch March 6, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants