Fix Bundle target print column #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
cert-manager-prow
bot
added
dco-signoff: yes
|
/cc @inteon |
|
Thanks for the PR, I tried to find a way to be smarter with the JSONPath, but I did not find any (please help if you are reading this and you are a JSONPath expert). |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the print columns were left behind when removing the copy of
targetunderstatusin #230 and when introducing the opt-in for secrets as targets in #193.I tried to figure out a better way to show either the configmap or the secret target key, but I don't know if JSONPath supports it. But a bundle could potentially specify both a configmap and secret as target, so two columns are probably best anyway.
Fixes #343